Thomas Cooper

Results 47 comments of Thomas Cooper

I started hacking on this today. The workaround from @b7702e2 produces the best result (with hardcoded `name="container-structure-test.test"`). Tested on a fresh Jenkins 2.361.1 install with latest JUnit plugin (1119.1121.vc43d0fc45561). ```bash...

> 1 workflow awaiting approval > First-time contributors need a maintainer to approve running workflows. [Learn more.](https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks) Looks like it's waiting on a manual approval. @loosebazooka would you mind kicking...

@nkubala or @dlorenc , would either of you folks be able to approve the workflow & run the tests (should be passing now)?

> I love your examples above; can you just explain what the benefits might be between these two for the developer? > > `Proxy sends sends an HTTP request to...

Here's a general design: ```mermaid flowchart TB subgraph OPA direction LR C[OPA server] -.->|"{input: {email, commiter}}"| D[authorized_committers.rego] C -.->|"{input: {url}}"| E[authorized_repos.rego] C -.->|"{input: {...}}"| F[...] end A(committer) -->|push| B(git proxy)...

Sorry for the delay. I do see the need to balance simplicity in git-proxy via built-in features and checks vs embedding another policy framework or engine into the project. This...

Let's keep this issue to track the specific OPA enhancement. I'll comment on the original extensibility issue (#47) and add details and a design proposal for how we can support...

> The current 'manual approval' flow a asynchronous flow - i.e. we are waiting for a human to come in and hit an approve button to unblock the processing chain.......

@JamieSlome for sure - I'll work on putting together a small PoC in the next few weeks. We probably want to step through each of your points and discuss how...

Done. I think using a full-fledged configuration library like [node-config](https://www.npmjs.com/package/config) would cut down on a lot of boilerplate and we can likely remove the requirements for increasing test coverage if...