Kun CHEN

> For Windows, you might want to add this: > download_url = os.path.join(url, filename).replace('\','/') > > due to the os.path.join issues `\` is an escape character so it's better to...

不知道是因为我改出的问题还是原有的问题，edge打开网站的时候好多地方冒出来了这种小圆点。（电脑端chrome跟手机端都没有问题）  

I'd love to fix it, but I've run into some problems. The `glover_hrf` was implemented by the `_gamma_difference_hrf` function, which was used by several other hrf functions. https://github.com/nilearn/nilearn/blob/cc11c85cd222632dcaf7c51005b549f75a49bbc4/nilearn/glm/first_level/hemodynamic_models.py#L103-L128 https://github.com/nilearn/nilearn/blob/cc11c85cd222632dcaf7c51005b549f75a49bbc4/nilearn/glm/first_level/hemodynamic_models.py#L18-L74 There...

> Hi @const7 and thanks for looking into this ! 👍 The `_gamma_difference_hrf` is a private function used in different places to factorize the code. Because it is private, we...

Thanks for your explanation! So the constants `c1` and `c2` are just used for the normalization of each gamma, right? I'm still confused about two things: 1. What does the...

Thank you! Question 1 is fully answered. Question 2, more specifically, I'm confused how things like `delay / dispersion` or `dt / dispersion` in `gamma.pdf` correspond to `n1`, `t1` in...

I'm totally lost in the hrf calculation here https://github.com/nilearn/nilearn/blob/cc11c85cd222632dcaf7c51005b549f75a49bbc4/nilearn/glm/first_level/hemodynamic_models.py#L68-L71 The parameter statement of `scipy.stats.gamma.pdf` is `pdf(x, a, loc=0, scale=1)`, and `a` is the shape parameter. So `delay / dispersion` and...

@dangom Thank you! I got almost the same result using this code compared with the original one. @bthirion Sorry but I still couldn't understand why `dt` should be used here....

Thank you. It seems that we have to change the `_gamma_difference_hrf` directly since we cannot get equivalent normalized gammas (things like `peak / peak.max()`) by passing different parameters.

It worked. Thanks you! I also tried to install `timecorr` on a new machine using different python versions (`3.7` and `3.9`) with different installation approaches (`pip`, `conda` + `pip`, or...