Colin Lienard comments

Results 16 comments of


                                            Colin Lienard

Content not statically generated when using `queryContent`

Thanks for your answer (and sorry for my late reply, I was on vacation). I managed to get it to work using `ssr: true` and `nuxt generate`. However, when I...

feat: add time-picker

I don't think I've forgotten anything major, but I'm curious to see from your review whether I did things right or not. Just not sure how the anatomy part in...

feat: add time-picker

Hey @segunadebayo any chance to get a review soon? Let me know if I can do more Thanks!

[Suggestion]: add a 'metadata' prop for routes,for nicer configuration

Yep that's a good idea, would be similar to these probably: - https://router.vuejs.org/guide/advanced/meta - https://tanstack.com/router/latest/docs/framework/react/guide/static-route-data I will look into it!

[Suggestion]: add a 'metadata' prop for routes,for nicer configuration

You can leave it as is, I'll link the pr to it :)

import { navigate } from "sv-router/generated" in .svelte.ts files

Did you follow the step about the tsconfig extending from the generated one in the docs? https://sv-router.vercel.app/guide/file-based/setup If you're using a aliases in your tsconfig, it will override the alias...

📌 Contribute to Ark UI: Components Ready for Implementation

Hey, I would like to continue my work on the time picker here

fix: correctly handle cancellation of navigations

> Hopefully cancel all navigations if they're not the most recent one. Old logic did not work from my tests. @richardjelinek-fastest Curious to see your method of test, I didn’t...

fix: correctly handle cancellation of navigations

I don't see the issue in your repro 🤔

fix: correctly handle cancellation of navigations

I was still not able to reproduce the issue...