Cody Leff

Results 18 comments of Cody Leff

Closed to refocus on additional work required given clarified requirements.

> @codyml Thanks for the new feature, I have tested this feature in my local. there are 2 issues. > > 1. The drill detail modal always sends `force query`....

> For the ideal, the `force` is sent when the `force refresh` is selected in three-dot menu. IMO, this can be optimized later, just keep `force=false` for all of requests....

> Some more comments from manual testing: > > * When resizing the modal, the pagination should stick to the bottom. Also, there are 2 vertical scrolls there. I believe...

All issues should now be fixed, with the exception of D2D on values containing commas, which is being worked on in separate PRs (#21151, #21124).

@kgabryje I'm not sure if this is fixable or if it was like this before, but I noticed that if you have unsaved changes and try to navigate to Dashboard,...

@kgabryje Also not sure if this was intentional, but I noticed that if you edit the chart title but clicking directly on the rendered title and edit it, the "Altered"...

> > > > I think it makes sense! @kasiazjc wdyt? > > > > > > > > > Good point, I'm thinking - maybe for consistency we should...

Tested each viz type and left 2 notes for issues I found, otherwise looks great!