Patrick Marx

Results 14 comments of Patrick Marx

> @codesorcery do you have a valid email address we can use to sign off the commit? This is a requirement of https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md#sign-your-work Updated mail address in the PR comment....

We also need this merged, since otherwise reading Hudi tables with empty partitions will fail when they are read from a read-only volume. This will then lead to the query...

Since this PR has been open for almost 4 months: What steps are there to do, to get this one merged? We are currently forced to maintain our own fork...

#20151 fixes the underlying problem of Trino failing on empty Hudi partitions. So when this PR gets merged, there should be no reason to handle it here. So it should...

Do I see it right, that one then has to explicitly set `hudi.ignore-absent-partitions=false` to get the current behavior? IMHO, that should then definitely be highlighted in the release notes, since...

@itholic thanks for reviewing! I added some small changes to the tests, to make them compatible with NumPy 2.0. MR description is updated accordingly and formatted according to the default...

> There are some linter failures: https://github.com/codesorcery/spark/actions/runs/9708335267/job/26795030107 Added `# type: ignore[arg-type]` to the affected lines, since `legacy="1.25"` is only implemented in `numpy>=2` and we're checking that the code path is...

> Have we test this changes against numpy 2.0? I've tested it on my local workstation, as written in the PR description. There aren't any CI jobs testing with NumPy...

> @codesorcery do you mind creating a PR to set the upperbound at `setup.py` like `numpy < 2`? I think NumPy release will affect 3.5 users too. @HyukjinKwon you mean...

@HyukjinKwon here's the PR for `branch-3.5` limiting `numpy