Adrian Cole
Adrian Cole
here's a fix (in java) with some comments explaining https://github.com/openzipkin/brave/pull/875
actually 1xx is complex as usually they are not terminal status iiuc ex 100, 102 and 103 are interim status codes, not the final status that closes the request. this...
@jquatier for the IPv4 question, assuming there's no js utility, you'd want to unpack the integer into 4 bytes and format it similar to how it is done in java:...
the data model used by batchrecorder is v2 so it can support ipv6. however, there's no data that supplies it at the moment.. everything assumes ipv4 still iiuc https://github.com/openzipkin/zipkin-js/blob/a8ab73d26157a3b25b207425e2808ee39105afa1/packages/zipkin/src/batch-recorder.js#L119
suppose this was a request to backfill tests
> Another option could be to move it to attic? > I don't think it is significant enough code to do that. Usually we only attic things that are repo...
I think we can implement this in a way that works for the current api as most samplers dont actually use the tracer in any way. mostly they need an...
> There are also some other problems, like how to protect zipkin-server from > potentially malicious requests, if it's exposed to the wide Internet? > > good point in general,...
There is some discussion about "http.template" which sounds like this change can afford. Not sure if we should change default because it is what most zipkin instrumentation use since the...
are these tags http headers?