Adrian Cole

Results 2046 comments of Adrian Cole

this might not be relevant, so don't anchor your brain to it, too much https://github.com/othiym23/node-continuation-local-storage/issues/36

ack. this would impact any middleware. There's a slight problem which is that we are writing bug guards and the bug guards could have bugs. anyway we can try to...

good point. in the brave code, I noticed this and added a helper (which could probably be hidden) https://github.com/openzipkin/brave/blob/master/propagation/aws/src/main/java/brave/propagation/aws/AWSPropagation.java#L201 Recently, AWS have open sourced their SDKs so we can probably...

not sure if most actually do, but there is probably value in doing this. It would be nice if proto3 had constants as if it did we could generate them...

since zipkin is very much like google cloud trace, we can probably borrow approach from them https://github.com/GoogleCloudPlatform/cloud-trace-nodejs

https://github.com/grpc/proposal/pull/14 indicates a future interceptor model (which doesn't necessarily help now)

the name is a bit misleading.. there's no batching although it does keep references to many spans. The http logger (reporter) actually bundles messages, if you look at it.

related: pinged slack to see if kafkajs is known to work in browser env or not https://kafkajs.slack.com/archives/CF6RFPF6K/p1561867307001500

kafkajs won't work on browser. Another TODO here is to refactor the tests as currently they take over half the time of running all tests including typescript. (>30s out of...

yep good point @jcchavezs and @eirslett, we've had good luck with testcontainers in java and it has a wait strategy we can use for containers listen ports