Adrian Cole

Results 2050 comments of Adrian Cole

ok it is because starting in cassandra 4, enable_sasi_indexes is disabled by default in the normal image. Things won't function without this setting. I'll look for a way to enable...

looks like there's no way still to override cassandra settings without changing the yaml file https://github.com/docker-library/cassandra/pull/233#issuecomment-1022803135

so it would be better to at least fail if cassandra is started without sasi-enabled, yet search is enabled

The main issue is SASI is disabled by default in cassandra 4. So, and you need to find a way to enable that (probably bring your own yaml). If this...

I think we can check this heuristically. Basically the schema silently fails, so we can double-check things that should install if SASI is enabled, but didn't https://github.com/openzipkin/zipkin/pull/3741

@PierreF 3.1.1 on the way out will be explicit with the error in cassandra (swallowed by the healthcheck I think). The main thing is we cannot change the SASI settings...

as the javascript infrastructure changed, possibly there's no issue any more. If there is, please reply back.

currently looking at renovating this one

ok 🤞 salvaging a three year old change!

drive by comment. internally probably good to stay imperative as there is measurable overhead doing things functionally especially if arbitrary vs imperative. benchmarks will show the additional allocations and higher...