Adrian Cole

Results 2050 comments of Adrian Cole

I will study this and help merge it this week

This change is in the same line as this https://github.com/openzipkin/zipkin/pull/3503#issuecomment-1896131370 where basically something is writing data that is not in zipkin's format into zipkin's schema. We can change the NPE...

At the moment there is not enough help on this project. Until that changes, we will not entertain any change that makes it easier to use unsupported data in our...

this project doesn't package generated proto code for external use. We have `SpanBytesEncoder.PROTO3` which does the same thing, and has no deps. zipkin-proto3 is only used in our tests. we...

closing this as it is very out-of-date, and the related issue hinted at a non-standard setup.

zipkin was renovated at the end of last year including updates to all things including JRE and alpine. Closing this out, but if you have something with a current version,...

https://github.com/openzipkin/zipkin/pull/3671 finishes this

the problems here were mostly test lifecycle in nature (properties read at the wrong time), so https://github.com/openzipkin/zipkin/pull/3671 walked around them by using testcontainers+dynamic properties instead of nested initialization. https://github.com/openzipkin/zipkin/blob/master/zipkin-server/src/test/java/zipkin2/server/internal/eureka/ITZipkinEureka.java

sorry no one answered you that while QUERY_ENABLED can disable the UI, it is a shorcut for ZIPKIN_UI_ENABLED. I'll make one named UI_ENABLED so it is easier to find.

https://github.com/openzipkin/zipkin/pull/3731