Peter Gafert

Results 223 comments of Peter Gafert

I'm not sure what your specific requirements are. But principally I would say "of course" 😉 If you pick up the rules in some way yourself you can always just...

Hmm, I'm not sure about this 🤔 I've already stated in other cases that ArchUnit never set out to support the full set of PlantUML syntax. Because, doing so would...

Sorry, I just saw that you already told your project has only 120 classes :see_no_evil: So then 90 sec is definitely way too long and I think you just pull...

Downside could be that you have no/wrong information about classes outside of your project. I.e. the classes that are not directly imported will be stubs, they can miss annotations, superclasses...

I guess it would make sense to add the types found within this custom condition to be just part of `JavaClassDependencies`, right?

Yes, I'd be open to add this 🙂 If somebody wants to jump in and create a PR I'm open to support. Otherwise, I put it in my queue 🙈

Even though the concept of "loc" doesn't exist yet, so there needs to be some pre-analysis how to map this, or if we can actually track the loc somehow... Or...

Big apologies for the slow follow up! I was unfortunately deeply overloaded over the last months 🙈 @tfij Thanks for the initiative, but to be honest I'd like to discuss...

Just that from my point of view the idea never was that ArchUnit can understand **all** PlantUML diagrams. It was always meant to just take a well-defined subset (that keeps...