Shelley Vohr
Shelley Vohr
#### Description of Change Closes https://github.com/electron/electron/issues/42003. Fixes the following issue when setting autoResize on a `BrowserView`: This was happening because `setBounds` accepts a `gfx::Rect` and we were trying to pass...
#### Description of Change Fixes the following CHECK in [`View::AddChildViewAtImpl`](https://source.chromium.org/chromium/chromium/src/+/main:ui/views/view.cc;l=3071;bpv=1;bpt=1?q=AddChildViewAt): ``` [23853:0507/174950.101294:FATAL:view.cc(3081)] Check failed: view != this (0x130006c2000 vs. 0x130006c2000)You cannot add a view as its own child ``` and...
#### Description of Change Closes https://github.com/electron/electron/issues/32857 Closes https://github.com/electron/electron/issues/41903 Refs https://github.com/electron/electron/pull/19159 This PR replaces our dialog implementation on Linux with upstream `//shell_dialogs`. This both streamlines and simplifies our dialog logic, and...
#### Description of Change Closes https://github.com/electron/electron/issues/41956. Refs: https://chromium-review.googlesource.com/c/chromium/src/+/4916277 The above CL changed `window.center()` behavior on Windows/Linux (which use `Widget`) such that the window is now centered relative to the parent...
This PR exposes a constant `OPENSSL_IS_BORINGSSL`, which could then be used from JS like: ```js const crypto = require('crypto'); const usingBoringSSL = crypto.constants.OPENSSL_IS_BORINGSSL; ``` and will then allow Electron to...
Backport of #41960. See that PR for details. Notes: Fixed an issue where `setTitleBarOverlay` didn't work as expected when called on `BaseWindow`.
I'm using the stock deploy to Heroku as well as your Actions fork: ``` - name: Setup upterm session uses: owenthereal/action-upterm@v1 with: limit-access-to-actor: true upterm-server: wss://electron-upterm-5a8dedcc6c26.herokuapp.com ``` The deploy was...
In our latest V8 roll via Chromium update, we're seeing a lot of crashes in heap snapshot tests - we've tracked these to https://bugs.chromium.org/p/v8/issues/detail?id=14617 and the associated CLs therein. Failing...
Looks like trop is struggling a little with transitive backport updates: The needs-manual should have been removed when the in-flight was added
#### Description of Change Align our logic better with the approach taken by [upstream](https://source.chromium.org/chromium/chromium/src/+/main:chrome/renderer/chrome_content_renderer_client.cc) for logic delegated to `ElectronExtensionsRendererClient`. #### Checklist - [x] PR description included and stakeholders cc'd -...