Shelley Vohr

Results 126 issues of Shelley Vohr

##### Description of change This is a draft feedback request for adding baseline ninja support to `node-gyp`. `gyp` already supports `ninja` out of the box, so this installs ninja to...

This one might be a little trickier - the request function will also likely just default to prefpane opening. Only implemented on 10.15 and beyond.

enhancement
help wanted

Fixes a compilation error encountered in Electron as a result of Chromium enabling the `-Wimplicit-const-int-float-conversion` compilation flag in [this CL](https://chromium-review.googlesource.com/c/chromium/src/+/3001416). Compilation Failure ``` ../../third_party/squirrel.mac/vendor/ReactiveObjC/ReactiveObjC/RACQueueScheduler.m:52:62: error: implicit conversion from 'long' to...

Fix missing repository invitation icon. Before: After: GitHub Notifications UI Reference:

When loading a local fiddle from a directory with multiple files, the Fiddle fails to load and results in missing and/or empty editors: Probably refs https://github.com/electron/fiddle/pull/1120 - it doesn't look...

:beetle: bug
area:editors

When i click Run on an arbitrary version, the button remains on "Run" and i see this: Screenshot from devtools:

:beetle: bug
platform:windows

http://electronjs.org/docs at present is a bit cluttered and difficult to parse through; it would be great if we could consider a new visual organization of this data.

enhancement
area:docs

https://chromium-review.googlesource.com/c/v8/v8/+/3620285 was merged recently and causes a _ton_ of failures in a variety of tests (~50 or so, `parallel/test-worker-esm-exit` as an example): ``` # # Fatal error in ../../v8/src/api/api.cc, line...

Refs https://github.com/nodejs/node-core-utils/pull/388. Some of this hard to test, since it involved taking real steps that we take during releases. I've chosen to seek active confirmation more here than in the...

Work In Progress

Seen here: https://github.com/nodejs/node/pull/35405 When i proceed anyway, each message nevertheless has all requisite info: ``` node on git:v12.x-staging ❯ git rebase upstream/v12.x-staging -i -x "git node land --amend" Executing: git...

bug