Shelley Vohr comments

Results 509 comments of


                                            Shelley Vohr

fix: `BrowserWindow.center()` should center relative to screen

@VerteDinde yeah - i think this might be the reason we didn't have tests already :( it passes on each platform locally, but acts really weird in CI. Might need...

fix: `BrowserWindow.center()` should center relative to screen

@nornagon done!

[Bug]: Calling preventDefault on BrowserWindow close event still destroys BrowserViews' webContents

Tracked initially to https://github.com/electron/electron/pull/35658 - your gist actually crashes after that first PR. That crash is then fixed in https://github.com/electron/electron/pull/41154, producing the current behavior. Ah - looks like this change...

feat: exit app instance when main package throws error on load

@Mrnikifabio could you rebase this?

[Bug]: <input type="file"> is not showing dialog on click

Looks like i fixed this incidentally to another bug: https://github.com/electron/electron/pull/41966. The PR has been backported to 30 already and will be out in the next patch release!

Electron SIGSEGV Error When Running in Docker Container

Could you please attach a crash dump to help us get more information? You can collect them by adding the following snippet to your main process code, before app.whenReady: ```...

feat: Added Browser Window Click Event (Issue #24351)

Closing as abandoned given concerns above.

feat: add window shadow for frameless window on Wayland and WCO on Linux

@ruihe774 after some discussion myself and Deepak have come to the tentative conclusion that it's likely more expedient in the short term to try to land my initial PR for...

[Bug]: SIGSEGV crash when maximizing window

Noting from investigation @VerteDinde and i did: https://chromium-review.googlesource.com/c/chromium/src/+/5318955 is likely the culprit here!

feat: add cumulativeCPUUsage to AppMetrics and CPUUsage

hey @rcombs - thanks for this! We'll try to take a look as soon as we can. Could you please address the lint issue [here](https://app.circleci.com/pipelines/github/electron/electron/79997/workflows/d4d40ddf-6c1b-4085-b6f9-4023c6f9b9a4/jobs/1698273?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) in the meantime?