Shelley Vohr

Results 509 comments of Shelley Vohr

Electron 18 isn't supported and hasn't been in some time. For us to continue triaging this issue, it must be present on a [currently supported](https://www.electronjs.org/docs/latest/tutorial/electron-timelines) version of Electron. This issue...

Combining with https://github.com/electron/electron/issues/41974

Looks like this might be an upstream-instigated change, as our Windows implementation hasn't changed in ~6 years: https://github.com/electron/electron/blob/76f7bbb0a8db04c002293b2753f24146518737b5/shell/browser/native_window_views.cc#L1073

Good news and bad news: I found the CL that caused this after a quick sprint through Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/4916277, but the CL indicates the previous behavior was unintended and that...

@yangannyx if you could, it'd be helpful to make this: > Dragging the parent window in MacOS will also drag the child windows to preserve their distance/position to the parent...

@t57ser thanks! agree it should never crash - will investigate soon :)

@t57ser couldn't repro with the following: sample ```js const { app, BrowserWindow, WebContentsView } = require('electron') function createWindow () { const win1 = new BrowserWindow({ title: 'win1' }) const win2...

@t57ser confirmed, thanks! looks like https://source.chromium.org/chromium/chromium/src/+/main:ui/views/view.cc;l=3072?q=AddChildViewAt is the root here

Can't reproduce this locally: ```console nodejs-readdir-test on git:main ❯ e node node.js 1:50PM Running "/Users/codebytere/Developer/electron-gn/src/out/Testing/Electron.app/Contents/MacOS/Electron node.js" { node: '20.12.2' } [ 'äöü.txt' ] ```

@oliverschwendener you're right - my bad! reproduced on windows - will investigate further. Interestingly, this doesn't happen in the main process. Running: ```js const { readdir } = require("fs"); const...