Konstantin
Konstantin
I think, all `chr` calls should be replaced with `six.b(chr(...))`, all `isinstance` checks are redundant. Good catch anyway! Perhaps add a test for that?
It's a bit more complicated. So CPython builds success as well as PyPy3 build, but environment for PyPy (2) fails to set up. I think we need another tox image...
Well, we don't actually use it in CI so we can either kill it all or just change tox config to anything we find useful
I remember doing this on purpose. Waiting for a timeout wasn't a problem, as I had multiple processes and while some of them were waiting for timeout, others were doing...
Yes, most of the functions in `gsm.py` deserve reversed versions: `glue_parts`, `decode`, we don't have those implemented.
Please, add/update requirements for custom sequence generator to README as potentially breaking changes
I take that back, I thought you create other implementation instance if it is passed
confusing part is that `start_sequence` will not work with custom sequence generator
So I think we don't need this argument in `Client` constructor. You can create `SimpleSequenceGgenerator` instance with desired `start_sequence` and pass this instance to the client's `__init__`
I vote for `SimpleSequenceGenerator`, ask for some documentation and/or tests (but I don't insist), and vote against `start_sequence` in Client