Craig Nishina comments

Results 9 comments of


                                            Craig Nishina

Please stop +{number} this PR. This doesn't help...

Yes this should be marked as a breaking change to the random option.

Please rebase. Protractor 6 has been updated and there were a lot of changes. Also please use native promises. Thanks.

Resolved a conflict I created from a previous merge. Once this passes, I'm adding it in.

Also thanks for pinging this again @tymfear. The notification was buried. Also thanks @Amy-Lynn for this PR and the test additions.

Yes, this will. It will be released for Protractor 6. It will be available in beta soon.

Could you sign the CLA and rebase? Also could we use ~0.5.11? Is there a reason to pin the version of the source map support?

code to this example: https://github.com/cnishina/protractor-cookbook/tree/blockingproxy/protractor-blockingproxy

Does not work. Placeholder.