Carl Mercier comments

Results 61 comments of


                                            Carl Mercier

Implement way to automatically detect dark/light terminal

I have submitted a PR.

Automatically detect light terminal on initialization. Implements #150.

I also implemented Apple Terminal light mode detection. One thing to keep in mind, though, is that this method sets the color scheme when the shell is first initialized. If...

Automatically detect light terminal on initialization. Implements #150.

It'd be great if we could only rely on env variables but it's not the case. However, that slight slow down would only happen on Apple Terminal, and if `MCFLY_LIGHT`...

Automatically detect light terminal on initialization. Implements #150.

See my implementation here: https://github.com/cantino/mcfly/pull/151/commits/55554beb8fd94a12edb3c28ca9ff682b87f59ef8

Automatically detect light terminal on initialization. Implements #150.

In my opinion, Mcfly should always try to do the right thing automatically without the need for any configuration, which is why I think it'd be wise to have something...

Consider 'ctop' rename

I suggest `ccTop`. You know... like the band. 🤣

Comments get lost when generating annotations

Yes but obviously nobody remembers to do that on a large team :) On Jul 29, 2022, 8:30 AM -0400, alexeyr-ci1 ***@***.***>, wrote: > It works to add a blank...

Option to add a blank line between annotation and class definition

CI is broken -- failures are not related to the code in this PR.

Incompatible with Rails 7

If it helps, I was able to get past the stack overflow error like this: https://github.com/rails/rails/issues/44157#issuecomment-1013607633 But then my code crashes later on.

Proper Notification object comparison

No because to_bytes can throw an exception if the payload is too large. That's why I did it this way. But I see what you mean. Perhaps we should actually...