Carlos Mendible
Carlos Mendible
@DannyDS do you have a test that replicates the issue?
> what happens if two ingresses have same priority? Missed that one! I added the check for that case in `getListenerPriorities` --> 27dfb60
go vet is failing here: `cmd/appgw-ingress/main.go:228:2: misuse of unbuffered os.Signal channel as argument to signal.Notify` which is note related to this PR code.
@akshaysngupta can you take a look at this one? Thanks!
Can you try: ``` bash dapr run -d ../components -H 8080 --enable-api-logging --log-level info curl -v http://localhost:8080/v1.0-alpha1/configuration/ ``` where `components` contains your `azappconfig` component configuration.
> On further investigation, it seems some issue with `getAll` - > > ``` > ➜ examples git:(feature/config_unsubscribe_api) ✗ curl -X GET http://localhost:3500/v1.0-alpha1/configuration/pravin-app-config\?key\=config1 > > {"config1":{"value":"configval1_1"}}% > > ➜ examples...
This one is caused by this filter: https://github.com/dapr/components-contrib/blob/2b5650c2faa41f0a8d82862583497103776be49f/configuration/azure/appconfig/appconfig.go#L176 Current implementation only returns values for keys with label == `*`
Closing due to inactivity and lack of feedback.
@VILLAN3LL3 can you please rebase this PR with latest `master`
> @cmendible Is something still missing or can the PR be merged? Just need to know were is the `EmailAddressComparer` class used.