Caleb Brose

Results 23 comments of Caleb Brose

I took a deeper look into this yesterday and the issue here is more an issue in API parity. There are currently 2 endpoints to list codespaces by org: -...

@mislav yes it should be possible to fix in place, but I'm pretty concerned about > It seems very easy for an org admin to use that flag trying to...

Looking into this a bit, the `'` is added to prevent shell expansions and that behavior can be disabled by adding the `-e` flag: https://github.com/cli/cli/blob/e2f344fef4b34356004c9c0f3adf252f1cc0af2b/pkg/cmd/codespace/ssh.go#L683-L691 That said, it's really just...

I haven't updated the tests yet because I wanted to get a general 👍 on this approach before diving into them. Will update them accordingly once things are decided.

@mislav I've updated the logic to just check for existing `.pub` files instead of trying to generate them on the fly and also worked in logic to support `--config` from...

> I'm a bit worried about the performance implications of this change @josebalius there are a couple ways that the api call to fetch known keys can be short circuited:...

> My concern with one, is that in order to get the fast experience the user has to do something extra that they have not been doing until now @josebalius...

> If we find a codespaces.auto key, is it guaranteed that the connection will work? It is guaranteed that the connection authentication will work. It is however still possible that...

> Only thing is what happens if for some reason user needs to re-gen, should we provide some way of "resetting" or regenerating the key? Is there a scenario where...

@josebalius thanks for all the feedback/discussion here! I've added the short circuit existence check, does this look OK now?