Tomoya Iwata
Tomoya Iwata
I'm interested in working on this issue. May I work on it?
@zulinx86 Sorry. fixed it.
@zulinx86 Thank you for the review! > Add a commit message explaining the context like why this commit is needed fixed. > Fix all the unit test failures I believe...
> Could you please squash [3134792](https://github.com/firecracker-microvm/firecracker/commit/3134792ac78cd256b9b3b0eeebc4dfb6b44d5f87) and [33ced74](https://github.com/firecracker-microvm/firecracker/commit/33ced7453eb12edc785cb4c3a9e5d58a0cf1ed04) into one commit? Sorry. I made a mistake while rebasing. I squashed tow commits.
I thought the code was functioning correctly after the fix, but I've noticed occasional test failures. Could you please advise on the following issues? ## 1.Too many open files Sometimes...
> Mh, it would seem that it's still compiling everything multiple times judging by the test runtimes, and that's why its timing out? 🤔 @roypat Sorry for the late reply....
@MacOS CC: @bchalios Are you still working on this? If you are busy, may I handle it instead you?
@gjkeller I'm waiting for a [pull request](https://github.com/firecracker-microvm/firecracker/pull/4974) review...
@roypat I have made some adjustments, so could you please re-run the CI and review it?