Christopher Louvet
Christopher Louvet
@koshigoe, the pull request (https://github.com/rails/rails/pull/45140) I opened for this issue addresses your test cases too.
I think I spoke too soon about https://github.com/rails/rails/pull/45140 solving the problem. It breaks inversing for unsaved objects. I think it's possible to rephrase the reproduction steps a bit to point...
I ran into a similar issue recently. All testing from the plugin detail page worked successfully, but pull requests would not update the commit status. This comment (https://github.com/jenkinsci/ghprb-plugin/issues/787#issuecomment-656877126) suggested a...
I force-pushed an update here to resolve an `activerecord/CHANGELOG.md` conflict.
@ghiculescu, since it's been a while I'm giving this a little nudge. I'm happy to revise or close this pull request if this approach isn't preferred.
Thanks, @ghiculescu, I appreciate the response. I resolved the conflict with `activerecord/CHANGELOG.md` again.
@ghiculescu I made changes here in response to your review: I dropped the CHANGELOG addition, accepted your suggestion to use `unless` instead of `if !`, and revised the comment on...
Sorry for the noise here. I squashed the cleanup commits to make this pull request suitable for merging.
@lst4rksugarwork Sorry, but I wasn't able to make any progress beyond what I demonstrated here and on the attempted pull request: https://github.com/rails/rails/pull/45140.
Resolved by https://github.com/superfly/fly-pr-review-apps/pull/56.