Clément Lesaege
Clément Lesaege
The approve function should not revert if it approves a non 0 value, even if it's already non 0. The ERC20 standard states that the interface should prevent it, not...
"betwen"->"between"
"louch" -> "launch" By the way, is there a reason why transferring 0 should be treated independently? What prevents it from fitting in the general case?
This function refers to the actual token, not the clone. This mistake must have been made by copying https://github.com/Giveth/minime/blob/master/contracts/MiniMeToken.sol#L342
# Kleros Governor Bounties This is a bug bounty on the [Kleros Governor contract](https://github.com/kleros/kleros/blob/master/contracts/kleros/KlerosGovernor.sol). The contract is deployed on mainnet but isn't set up as Kleros governor yet. If a...
See https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/LinguoToken.sol#L257 which doesn't behave like Linguo. https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/arbitration/Linguo.sol#L246 In order to keep the deposit related to the translation value, we need to use Uniswap v2 to get the price of...
https://github.com/kleros/kleros-interaction/blob/master/contracts/standard/permission/ArbitrablePermissionList.sol
See the example of should-refill in http://1corp.io/snow/docs -Function with the prefix should_ and the same parameters. -Return True if need to call. Ideally the standard should allow to do: When...
See comments in this file https://github.com/kleros/kleros-interaction/blob/master/test/multiple-arbitrable-transaction.js