Christophe Le Saec

Results 14 comments of Christophe Le Saec

So, i used ICU and add possibility to provide a call back function instead of is_avro_id. (_For the second, users have to be very careful, it can lead to errors_)

> I see, you use AtomicInteger just as a mutable boxed integer, and don't actually care about its atomicity with regard to other threads. Yes

Indeed, AtomicInteger, atomicity is may be too much, and an array of size one (int[]) may be to blurry, i will create a specific private class for that. For optimization...

So, in the example `31*(31*(31*(31*(31*(31*hash(f1) + hash(f2)) + hash(f3)) + hash(f4)) + hash(f'1)) + hash(f'2)) + hash(f'3)` ? Indeed, that sounds logic.

So, i put hashcode calculation logic in an internal class, so counter became a simple int and 31* is apply to each step and code is easier to read.

> rewrite-maven-plugin Done, but with manual fixes because some tests named testHashCode, or testToString can't be renamed without "test", some tests have "extends" classes or other have explicit calls, and...

Just a question about proposed code, Why put methods **customRead** & **customWrite** in Parser.Names class (which is a simple registry of known schemas), and not directly in Parser class, or,...

PR approved (_as code for mangle is moved from SpecificCompiler to SpecificData_) with some remarks : - Mangle can transform word with point as "dummy.int.float" into "dummy.int$.float$" for example, as...

@hmsantos, i'm sorry, i forgot this PR, at this time, i didn't had right to merge PR. Nevertheless, you have to resolve conflict before merging.

Not on my side, I won't be able to work much on avro now, sorry.