WEI-YU YEN
WEI-YU YEN
@andreyvelich Can you help review?
> tenzen-y Thanks for the comment. Removed.
@andreyvelich @tenzen-y I think there's a simple way to fix this. Can I get a review again?
Hi, I am in a travel. I’ll have a commit next Mon to address the comments. Can you wait?Sent from my iPhoneOn May 24, 2024, at 3:32 PM, Yuki Iwai...
@tenzen-y the failed flow looks like a transient error. Can you help rerun again? ``` 61.59 Get:80 http://ports.ubuntu.com/ubuntu-ports focal-updates/main arm64 libcurl3-gnutls arm64 7.68.0-1ubuntu2.22 [213 kB] 62.04 Get:81 http://ports.ubuntu.com/ubuntu-ports focal/main arm64...
> Generally, lgtm > > Could you extend the PyTorchJob integration test to verify the validations? > > https://github.com/kubeflow/training-operator/blob/bd90bf4b7cf9ef99bd4b5a3fecdb20abfcb7177f/pkg/controller.v1/pytorch/pytorchjob_controller_test.go#L119 Updated