cjserio

Results 19 comments of cjserio

It seems like if we don't allow automatic uploads, we can simply put more files in the proper crash UUID's 'attachments' folder and they get uploaded auto-magically. This is a...

+1 from me. It'd be very useful if Drogon could properly handle arrays of parameters. It's not part of the RFC but it is industry standard for many years.

Ok THIS behaves strangely. OnDocumentAvailableInMainFrame does get called and if i use that `browser` I get back TRUE. ``` void myClass::OnDocumentAvailableInMainFrame(CefRefPtr browser) { printf("OnDocumentAvailableInMainFrame: Browser says document %s\n", browser->HasDocument() ?...

Ah of course, they're ref counted. So this code: ``` void myClass::OnDocumentAvailableInMainFrame(CefRefPtr browser) { printf("OnDocumentAvailableInMainFrame: Browser says document %s\n", browser->HasDocument() ? "True" : "False"); printf("Is Same Browser: %s\n", m_browser->IsSame(browser) ?...

I'm polling the cached browser every frame and it's False before and long after the callback from OnDocumentAvailableInMainFrame. It doesn't seem like I'm mis-timing it.

From our application's main loop. Once the browser's loaded and we get OnAfterCreated called, we stash the m_browser instance to communicate with the browser during its lifetime. So we're polling...

Yes, this line is being hit: https://github.com/chromiumembedded/cef/blob/81a0648ee1069b2464791249630fd5cbe41bfa1c/libcef/browser/browser_contents_delegate.cc#L478C5-L478C18

It's definitely after OnDocumentAvailableInMainFrame though I'm not exactly sure how to compare the frames properly.

Hello! I still assert this is a bug and should be reopened. I believe the HasDocument accessor exists to be "polled" so that events such as OnDocumentAvailableInMainFrame don't have to...

Yes PLEASE! This is shutting down my Drogon application in which the web-server is not a critical component! Let the application decide what to do!