Jonah Jeleniewski

Results 75 comments of Jonah Jeleniewski

@tada5hi By any chance, is your `executableName` different from your `productName` on macOS? This feels related to: https://github.com/electron-userland/electron-builder/issues/6962

> Is this something that's on the `File System Access API` roadmap? No. > if not, have it been raised? Yes, and seemingly rejected. In fairness, it doesn't really make...

I've run into this problem with a component nested within a modal overlay. When focused, this nested component should completely swallow `Escape` keyboard events. As noted here, the overlay stack...

Totally understand that the maintainers have their own priorities, but I'd really appreciate it if this one could be looked at and hopefully merged. It would allow me to remove...

Agreed. Equivalent APIs in sonar-java: - https://github.com/SonarSource/sonar-java/blob/master/java-frontend/src/main/java/org/sonar/plugins/java/api/JavaVersionAwareVisitor.java - https://github.com/SonarSource/sonar-java/blob/master/java-frontend/src/main/java/org/sonar/plugins/java/api/ModuleScannerContext.java#L58

Thanks for those additional details, super helpful. 👍 I have a hunch that this is caused by the UTF-8 BOM erroneously appearing in the string data for the first line...

I've confirmed the problem. Looks like it is indeed a BOM issue, and should be easy to fix. When constructing a `DelphiFile`, we read the file in 2 different ways...

Thanks for the suggestion, and agreed with your assessment on the benefits of implementing better control flow analysis. This is definitely an area for improvement.

This one is a bit cursed... ```pas Comment = ^{; ``` Anyway, we'll definitely need to handle these caret-notation escapes as tokens in the lexer rather than high-level syntax structures...

> #### Notes: > * The `block_type` context appears to only be checked so they can surface a more appropriate error message to the user when a caret appears in...