Ciro Nunes comments

Results 8 comments of


                                            Ciro Nunes

Added promises that are resolved when the menu is closed.

Hey @brobo, thanks for using angular-off-canvas and contributing with it. There are some considerations before merging this PR: - [ ] Follow the [AngularJS Commit Message Guidelines](https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit) - [ ]...

adding instance variables to scope

Can you include a [Plunker](http://plnkr.co) with the use case? I wasn't able to understand why we need those properties in the scope.

adding instance variables to scope

ping @dretay

swipe to close/open the off-canvas

already added in the plunker sample

No suitable component definition found for container component

I'm experiencing the same when returning a portal. Interestingly enough, it works when using a class component instead.

Index.html is edited to blank

Thanks for reporting @HenriqueLimas. This should be something wrong with the use of `gulp-injector`. Can you please provide a guide to reproduce the issue? (e.g.: start a brand new project,...

Webpack4 compatibility?

I just created a PR for that :)

Webpack4 compatibility?

https://github.com/cironunes/flow-webpack-next-plugin