Muzaffer Cikay

Results 16 comments of Muzaffer Cikay

@roman-right Why do you not address this feature?

I cannot believe that after 8 years and 3 months this issue is still valid.

Use [modify](https://github.com/MongoEngine/mongoengine/blob/2cab8a079ff257d52e8af9b059cf5586378a147d/mongoengine/document.py#L288) instead

Fixed in [here](https://github.com/zmap/celerybeat-mongo/pull/72#event-7815460430)

looks like it is not going to be solved. So ovveride save method to set update and create fields ```py from datetime import datetime from typing import Iterable, Optional from...

> > The commit message should be "Add HttpException to avoid overriding" > > Done, @cikay ! Thanks for reviewing > > I edited the message and rebased against master...

> I just fixed vulnerabilities you guys said. thx for the comments and review. Could you please define typed_params out of conditions?

> > I just fixed vulnerabilities you guys said. thx for the comments and review. > > Could you please define typed_params out of conditions? `default` parameter needs to be...

I encourage you to not make the changes I requested in a separate commit. Redundant changes should not be available in the repository history. Could you please meld them?