chunwei
chunwei
The CI failed. Could you resolve it?
Why do you need these methods?
The title is not clear. Could you change it?
This PR comes from https://github.com/apache/calcite/pull/2092/ with some fixups. Besides, It is already reviewed by some members. I think it is good overall.
FYI: the commit message should be [CALCITE-4340] xxxxx
@gr4ve, do you still want to work on this? If no, I would like to take over if you don't mind.
Maybe we can merge it with another pr.
> > Maybe we can merge it with another pr. > > which PR? PR which is not trivial such as bug fix or a feature.
> Before merge this PR. I think maybe we should reach an agreement in Jira. Because this will be exists confuse in the future.(The code implement is different about the...
Could you merge the commits to one and rebase the PR, @jamesstarr ?