chunhtai

Results 504 comments of chunhtai

I also mentioned in https://github.com/flutter/flutter/issues/107045#issuecomment-1192830591 I feel the more we use imperative API the more trouble we will run into in page updates because the url will not be in...

@Skogsfrae I think the second solution is something we should support The problem with the first solution is that if user directly type /reusable-page in their url bar (assuming this...

@Skogsfrae Relative route is a separate topic, we should continue the discussion in https://github.com/flutter/flutter/issues/108177 imperative API also cause an issue for the redirection with context because there is no context...

copied from https://github.com/flutter/flutter/issues/99112#issuecomment-1197095743 >I'm reading about new features in go_router 5.0 and I might have an idea for using the same GoRouteData in different sub paths with relative routes (https://github.com/flutter/flutter/issues/108177)...

cc @justinmc Since you are working on context menu

all comments addressed and PTAL @yjbanov

I am also not sure what the expected behavior should be, the previous page may rely on the query parameter.

I think we either keep it, or the query parameters are only visible to the last match, WDYT? @johnpryan

The plan is to maintain a feature branch for all of the breaking changes and then we can merge everything at once.