Chris White

Results 37 comments of Chris White

While waiting for an official fix, the following wrapper script works for me (amend your beautify executable for beautysh to point at this script file, and make the file itself...

I'm seeing a similar issue with 5.22.1: ![screen shot 2018-09-21 at 8 29 31 pm](https://user-images.githubusercontent.com/1356204/45912863-4b16af00-bddd-11e8-86a8-5de1ed4ccd6f.png) So the checkstyle.xml is saying static first, but the Import Layout section of the Code...

Adapting the antMatcher link posted by @wojciech-soltys, the following works for my purposes (but by **NO MEANS** is exhaustive for all spring security annotations) ``` /** * Parse out Spring...

The equiv straight sqlalchemy example code works without issue: ```python import enum import uuid from sqlalchemy import Enum, Column, create_mock_engine from sqlalchemy.orm import declarative_base, declarative_mixin from sqlalchemy.sql.type_api import TypeEngine from...

Well the partial-fix seems to be addressed in a number of PRs (#24 , #165 - which i created not knowing #24 was already out there). There is still an...

I can confirm that if you **do not use** `sa_column` for the field, this is now working as expected with `sqlmodel:0.0.8` and `sqlalchemy:1.4.41`. However, a word to other who might...

An addendum - defining the enum with a string mixin (for nicer on-the-wire strings used with fastapi) using the following notation also breaks the type creation DDL (in that It...

I assume this could easily be fixed by amending the if statement order in [main.py:get_sqlalchemy_type](https://github.com/tiangolo/sqlmodel/blob/0.0.8/sqlmodel/main.py#L374) function to test the subclass is an Enum before string: ```python3 def get_sqlachemy_type(field: ModelField) ->...

While i can't tell you why, the following amendment resolves this warning for me: ```python3 # raises the SAWarning session.query(MyModel).where(MyModel.field1 == 'value').first() # Does not raise the warning from sqlmodel...

I've seen this in another ticket, and while not explicitly documented, https://sqlmodel.tiangolo.com/tutorial/fastapi/multiple-models/ notes to use multiple models and inheritance. For your specific example, refactoring as the following would provide validation:...