Chris Seeley

Results 23 comments of Chris Seeley

AdWords API has been turned down and replaced by the Google Ads API.

Thanks for raising this. I took a look at CVE-2023-40743. This library does not use the impacted `Service.getService` function. It creates service clients from [descriptors](https://github.com/googleads/googleads-java-lib/blob/main/modules/ads_lib_axis/src/main/java/com/google/api/ads/common/lib/soap/axis/AxisHandler.java#L199). For example, [here](https://github.com/googleads/googleads-java-lib/blob/main/modules/dfp_axis/src/main/java/com/google/api/ads/admanager/axis/v202308/LineItemServiceLocator.java#L87) is where...

As a workaround, you can explicitly set an xsi_type for these line items and zeep will correctly serialize it: ``` line_item['targeting']['requestPlatformTargeting'] = { 'xsi_type' : 'RequestPlatformTargeting' } ``` For background,...

So the request here is to validate that the parameter is able to be serialized to the xsi type rather than silently serializing as null?

Digging a bit into WCF it looks like this is thrown [when you get a 401 response](https://github.com/microsoft/referencesource/blob/3b1eaf5203992df69de44c783a3eda37d3d4cd10/System.ServiceModel/System/ServiceModel/Channels/HttpChannelHelpers.cs#L3785). So the question is when is this 401 happening and why. Can you...

Thanks for all the context! The method there will attempt to refresh the access token if it's expired, so it may still be a problem at the OAuth level -...

I took another look and I still suspect (per https://github.com/googleads/googleads-dotnet-lib/issues/216#issuecomment-503712290) that this is a general OAuth 401 that is bubbling up in an unusual way. @Swapygit is this happening for...

Since you're using the Web flow, the refresh token may stop working for a number of reasons: https://developers.google.com/identity/protocols/oauth2#expiration If this happens you need to have the user go through the...

Thanks for pointing this out. I updated the wiki to remove these lines. We also need to update the example code. For reference, here's the OAuth2 docs on redirect URIs...

The library is compatible with .NET core 6.0. I just created a new project targeting net6.0 to verify. Do you have any details about the error?