Christopher T. Kenny
Christopher T. Kenny
I see why we haven't implemented it. I would think just column 1?
Hi @cderv. No worries. Love the other projects going on at RStudio. I've used it before for submission. It worked fine and there were no real complaints from the editor...
Hi @cderv, it does look like they've changed the template in the last year or so, but it's more the same than not. I can work through your comments on...
These looks like different problems. @pinusm's issue is about environment scoping, as `lm` stores the call as-is, which will have the formula as "`f1`", but `f1` will not be defined...
Hey @dinglucy, are you able to run devtools::document() and see if that fixes the CI failure?
@CoryMcCartan, do you have any thoughts on this?
Yeah, I think the only thing we really need now is some tests. The existing checks seem to run well and everything is structured fine, so shouldn't be a painful...
Tests are added. One which runs the theme code and one which actually produces a plot if `vdiffr` is available. They're pretty simple but shouldn't be too restrictive.
Oops, forgot to check that. There's a little package[ `urlchecker`](https://github.com/r-lib/urlchecker). I suspect they may also be unhappy with the version number. We probably should have updated 0.0.0.9000 -> 0.0.1 or...
Good to go by me. Just fixed a small docs thing with the Elf theme.