Christopher Fujino

Results 432 comments of Christopher Fujino

> @christopherfujino I can, but I'm not sure what I would test. It's clearly a miss from the null-safety migration of this library. I guess because the `flutter` tool is...

> Hey @christopherfujino, just pinging to get your thoughts. Would love to merge this and/or update as needed. Thanks! whoops, sorry I missed this, LGTM.

cc @loic-sharma can you review this? As a non C++ dev, this looks like something we'd want :)

> I'm confused why this is opt-in and even optional. In what situation wouldn't you need the file to be formatted like the rest of the project ? How will...

Also happening on `Mac_ios integration_ui_ios_textfield` (on mac-28 like the other one) so I suspect it's bot-related rather than test: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20integration_ui_ios_textfield/4405/overview

Here are four consecutive builds from mac-28: 1. success: https://chromium-swarm.appspot.com/task?id=5bc45344788bb910 2. failure: https://chromium-swarm.appspot.com/task?id=5bc4583d62a43e10 3. failure: https://chromium-swarm.appspot.com/task?id=5bc4793594903e10 4. success: https://chromium-swarm.appspot.com/task?id=5bc49c8ef1ce8910

> Here are some failed builds from other bots: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20ios_defines_test/5373/overview (mac30) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20flutter_gallery_ios__start_up/5276/overview (mac27) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/5127/overview (mac6) https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/5086/overview (mac8) At least in https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20ios_defines_test/5373/overview, I see in the doctor there were actually un-sync'd...

tree currently red on this: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20microbenchmarks_ios/5164/overview on mac-25

https://github.com/flutter/cocoon/pull/1948 adds debug logging which will hopefully help diagnose this

Another instance, however this time no sign of the debug symbol message in flutter doctor or the ios-debug-symbol-doctor: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20flutter_view_ios__start_up/4535/overview