Christian Kral

Results 128 comments of Christian Kral

OK, so the summary here is so far: - We rather go for a simplified revision history format - We do not specify what revision date actually represents - We...

OK, then the **simplified revision history format** (without version numbers) is then: ![image](https://user-images.githubusercontent.com/4184218/173151645-a115a8dd-cd1b-4a06-913f-7c3ed97d234e.png) I fully understand: the more rules we have, the more rules will be broken and violeted. So...

OK. The block will **not be renamed** or marked as obsolete: The bug fix will be implemented and documented.

@beutlich Why is it asking again for signing the CLA? I just signed it at https://github.com/modelica/ModelicaStandardLibrary/pull/3742#issuecomment-792252602

> > @beutlich Why is it asking again for signing the CLA? I just signed it at [#3742 (comment)](https://github.com/modelica/ModelicaStandardLibrary/pull/3742#issuecomment-792252602) > > Because you (accidently ?) committed as `Christian Kral `....

@beutlich Thanks for fixing the merge conflict. On my opinion the performed changes look all good.

@HansOlsson Is it legal Modelica code to use different units in the elements of vector `a`? ```modelica parameter Real d(unit = "kg/s")=0.01 "Damping coefficient in kg/s (not the damping ratio)";...

@beutlich I suggest to keep the implementation with `Real` parameters then. OK?

OK, I will implement @beutlich's proposal then.

OK, as far as I understand the graphic annotations, this looks good. One question, however, before adding my review: Why is `preserveAspectRatio=false` in the proposal, whereas `Modelica.Fluid.Vessels.OpenTank` uses `preserveAspectRatio=true`?