Chris Seto
Chris Seto
## Description If a user's code panics within a [`pop.Connection.Transaction`](https://github.com/gobuffalo/pop/blob/main/connection.go#L150-L174) closure, `.Rollback` nor `.Commit` will not be called resulting in a leaked SQL connection. ### Steps to Reproduce the Problem...
Enabling ember-cli's fingerprinting adds environment.js to engines' asset-manifest as `filesToIgnore` does not take the fingerprint into account. This can be worked around be adding `config/environment.js` to the fingerprinting's `exclude` key...
Prior to this commit, defaultifempty would not appropriately detect the "emptiness" of struct types nor non-zero length array types. This was notable for nullable types when used as values, such...
We don't currently have a knowledge base containing known issues or limitations. This can result in duplicated issues, confusion, and frustration for our end users. The current proposal is to...
### This PR is stacked on top of others! Please consider reviewing those PRs first. This message will be removed once prerequisite PRs are merged and this one is rebased....
It was recently discovered that the [redpanda statefulset does not specify `.metadata.namespace`](https://github.com/redpanda-data/helm-charts/blob/308dc6fd3a08e30614a2072e3c856c3cab8aab73/charts/redpanda/templates/statefulset.yaml#L38-L43). We need to correct this and add a linter or test which asserts that all namespaced resources have...
There are currently two ways to set `additional_start_flags` in the redpanda helm chart. `statefulset.additionalRedpandaCmdFlags` and `config.rpk.additional_start_flags`. It seems that setting `config.rpk.additional_start_flags` will generate an incorrect `redpanda.yaml`. We should make the...
#### 161aa66a1688bf64df7d130d5dcf4a297f0d6a6d redpanda: assert backwards compat guarantees This commit utilizes `valuesutil.Generate` to assert the backwards compatibility guarantees of the redpanda chart's values.schema.json across all minor versions start with the 5.6.x...
The title is just a pun on ["out of the tar pit"](https://curtclifton.net/papers/MoseleyMarks06a.pdf). I bare no ill will against helm, just writing templates for structured data. The helm-chart is unmaintainable with...