chrisse74

Results 13 comments of chrisse74

Thanks for the explanation @mclow - working on it.

I had to drop three BOOST_DEFAULTED_FUNCTION() declarations (but commented this) to avoid "Uninitialized reference member" errors. Unfortunately the initializer list can only take one parameter, when using BOOST_DEFAULTED_FUNCTION.

Hi all, The error messages show that the newly introduced exception which is raised if SSL_CTX_set0_tmp_dh_pkey() returns with an error is triggering the failures in the CI. > 1: CppUnit::TestCaller.testGetSmall...

The error goes away when a libprotobuf which was compiled without optimizations is used. (O1 does trigger it)

In fact there are various valgrind Bugs regarding bitfields. * https://bugs.kde.org/show_bug.cgi?id=232872 (false positive uninit for float=0.0 if an unrelated bitfield was touched earlier) * https://bugs.kde.org/show_bug.cgi?id=406674 (False positive when reading bitfield...

This PR changes protoc thus some checked-in proto files had to be regenerated.

Hi @acozzette thanks for your reply. * The static_casts suppress the warning locally. * Disabling the warning in the port_def.inc suppresses it globally and maybe hides (more problematic?) cases in...

The way to go forward is by adding a suppression instead. See discussion for details, closing the PR.