Chris Price

Results 84 comments of Chris Price

@alisd23 was just asking me the same thing, PRs welcome - https://github.com/ScottLogic/d3fc/blob/master/d3fc.d.ts

Status by package in priority order - - [ ] d3fc - *requires updating after each package is added* (#1697, #1702) - [x] d3fc-chart (#1697, #1698, #1702) - [ ]...

A couple of minor things - * You shouldn't need the `.enter().select('d3fc-svg')` within the decorate function. `sel` is the top level `d3fc-group` element which supports the `measure` event. `.on(` is...

Any chance you could knock together a minimal codepen example skirting the problem?

Am I right in thinking your example shows how to achieve the desired behaviour?

You can get close with something like - ``` export as namespace fc; export = fc; declare namespace fc { function rebind(target: T, source: S, ...names: N[]): T & {...

Alternative approach would be to have rebind return the rebound function and perform the target assignment explicitly e.g. - ``` fn.prop1 = rebind(fn, other1, 'prop1'); fn.prop2 = rebind(fn, other2, 'prop2');...

No. There is an outstanding issue for TypeScript definitions but no plan to move over (#590). There are a few d3/d3fc patterns that are problematic to represent in TypeScript (e.g....

Whilst investigating, also consider prettier-eslint

I noticed that the files in `docs/*` are being linted.