Christopher Holmes

Results 14 comments of Christopher Holmes

There's a couple more features that we would need to port across subscriber's similar to those used in the Racecar instrumentation: - We would need to be able to extract...

@plantfansam yep, makes sense. Here's the view in jaeger: ![image](https://user-images.githubusercontent.com/799295/176505018-97ce609f-ee69-4875-ad7d-3b9028a9519d.png)

> Thanks again for this submission! > > I am curious about the choice to mixin the instrumentation separately of the processor object vs mixing into the built in instrumenter[1](#user-content-fn-1-5f7e614a36a1a95ce99b518b507ebc18)...

> hey @chrisholmes just ack'ing your followups, plan to catch up here otw. hectic week for me there's been some internal stuff going on at work. thanks @ericmustin! > one...

@arielvalentin (and @ericmustin), yes, I'm happy to raise a request for this. I've been exploring this further and I noticed that using ASN for batch messages runs into the similar...

@arielvalentin @plantfansam: I've resolved some conflicts and I _think_ that I've switched over to the new CI structure. Please let me know if I've missed anything.

@ericmustin, I was referring to the the comments made here rather than a specific doc: https://github.com/open-telemetry/opentelemetry-ruby/pull/737#discussion_r623876419

> We discussed this on the weekly SIG call yesterday. These helpers don't belong in `opentelemetry-common` - that's already a bit of a grab bag of utilities that needs to...

@dentarg @simi, our Dockerfile isn't easily shareable as our base image is also private. We've been trying to reproduce this on something similar, and so we can rule out dependencies,...

@arielvalentin a similar change to the grape instrumentation would also help my use case as we're often mounting Grape within rails. I can see about raising a PR for this.