Chris Chen

Results 17 comments of Chris Chen

@jpvajda @RIP21 Hello, I put a fix. I think use header will be a good solution for this issue. Please review the PR and let me know if it works...

@mpeyper I would like to contribute, I think the outline for this solution will be a similar solution used by `dom-testing-library` 1. We detect if we're in an environment that's...

Thanks @mpeyper I will work on the PR

I have been trying to find the fix for a typescript error. ![image](https://user-images.githubusercontent.com/10645051/122129966-c1f50100-cdeb-11eb-8f8d-b3f555388432.png) I am not sure how to fix it yet. and I am not able to use //...

> Give this a shot: > > ```ts > Object.entries(timerAPI).some( > ([name, func]) => func !== globalObj[name as keyof typeof timerAPI] > ) > ``` > > `Object.entries` returns `[string,...

@mpeyper I has been working on this issue recently, I changed the fackerTimer detection code to this ```javascript const usedFakeTimers = ()=>!!(global.setTimeout.mock||global.setTimeout.clock) ``` However, I have a hard time to...

> To be honest, I don't use fake timers when I write tests, so I'm also unsure of what the desired outcome is. > > I think the difference you...

> Now I'm even more confused about what the actual issue is here. There must be a reason dom-testing-library has such an implementation? > > Do they want it to...

> Yep, that makes sense to me. > > Just to clarify, no amount of running pending timers or advancing them before the `waitFor` will make it pass because the...

> ed to fake timers -- but in this case with the `legacy` option (which is discouraged by the main testing library but seems to work OK). Apologies for not...