Christian Franke

Followup from smartmontools-support ML: https://listi.jpberlin.de/pipermail/smartmontools-support/2021-February/000580.html

Consider to use `--json=o` to include original output as JSON array `smartctl.output[]`.

I agree that [linuxhw/SMART](../../SMART) and the similar project [bsdhw/SMART](../../../bsdhw/SMART) should use JSON output if smartctl >= 7.0 is available. With option `--json=o`, the traditional output could be easily extracted later...

JSON output does still not include all info from traditional output. ATA/SATA is fairly complete (see [ticket 767](https://www.smartmontools.org/ticket/766)), but SCSI/SAS and NVMe are not. Try `--json=u` to see affected lines...

Sorry for the delay. Issues found: - Only `ComSpec` is checked which would only set `WINNT=1` in (possibly rare) case that `make` is run from `cmd` or `powershell`. MSYS(2) and...

You're welcome. Further unrelated notes: - The default `PREFIX` should IMO be `/usr/local` to avoid accidental overwriting an installed package. - Using `override` is not recommended as it would require...

You're welcome. Backporting is IMO not needed as there is possibly no benefit for GSmartControl's use cases with a 7.4 pre-release instead of a 7.3 release and with the upcoming...

FYI: New official release 7.4 works with GSmartControl 1.1.4, so no need to backport anything. OT: In next GSmartControl release, you might want to show the drive database version number...

If downstream predefines certain *FLAGS, these should IMO always have preference. Here a working example for `configure.ac` which sets `_FORTIFY_SOURCE=3` if not pre(un)defined. A full check, which also detects compiler...

Thanks for the feedback. > Would changing the date in `#define _POSIX_C_SOURCE 200112L` from `200112L` to `200809L` avoid the need for `#define _BSD_SOURCE`? No. If this would work it would...