Chris Davis

Using ETWReloggerTraceEventSource to gather events just from a certain time start/stop doesn't include stacks

1

I wanted to use the relogger to gather all events that occur within a certain start/stop time in a trace and then write that to a new etl file. What...

QueryContextMenu is leaking HBITMAPs in explorer process

1

The bitmaps you pass to the menu items are getting leaked every time the menu is invoked in explorer. Please move these HBITMAPs to class members of CIShellContextMenu, create them...

I noticed your code was leaking a GDI object for the HBITMAP for the context menu. Added missing call to DeleteObject. Please update the version on your share and the...

When compiling with -Wextra-semi warnings get called out in this codebase for extra semicolons. This commit removes the extra semicolons.

Switch from llvm::StringRef to char* for Toggle name to prevent static initializers

1

Small change to switch from llvm::StringRef to char* to prevent incurring a large number of static initializers. See dump of static initializers before and after this change from a release...

This change eliminates a globally initialized mutex we are seeing at launch of chrome. This is created on demand from a helper function with a static local.

Looks like use after free for whatever the char* is pointing to in the InitializationConfiguration 2025-03-09T03:08:06.0300303Z ../../third_party/oneds_sdk/public/lib/jni/PrivacyGuard_jni.cpp:64:40: error: object backing the pointer config.NotificationEventName will be destroyed at the end of...

LogManagerBase.hpp still has issues with extra semicolon

1

A previous fix must have missed this ../..\third_party/oneds_sdk/public/lib/include/public/LogManagerBase.hpp(139,27): error: extra ';' after member function definition [-Werror,-Wextra-semi] 139 | LogManagerBase(){}; | ^ ../..\third_party/oneds_sdk/public/lib/include/public/LogManagerBase.hpp(144,48): error: extra ';' after member function definition [-Werror,-Wextra-semi]...