Choko
Choko
Hi @ldez - it's been more than a week so just checking in, what sort of schedule can we expect on this sort of code review? Happy to iterate on...
@ldez The default is to detect `io.EOF` and any variable prefixed with `Err`. I think this provides the least chance of false positives and can catch most patterns of reassigning...
Yes the job of the linter is to detect reassignment of global variables. The background for the linter is here https://github.com/curioswitch/go-reassign#background Some people prefer constant errors pattern to `errors.New` out...
> so the description of your linter must be explicit on that. Do you mean PR description? It says "public variables in other packages" which I think is fairly explicit...
> The weak default and the use of regex, give me the impression that you don't really know the concrete use cases of your linter, that's why I ask you...
Because golangci has its own suppression mechanisms, perhaps the pattern isn't as useful when invoked via golangci (it'd still be needed for CLI invocation in the binary itself). Would it...
Thanks @ldez! I've changed the config to a slice
Thanks @ldez sorry for the trouble. I had forgotten to rename the yaml field name and had a [bug](https://github.com/curioswitch/go-reassign/pull/4/files#diff-b126d19c61b7249f14710696139d71e966aa643a9a363ad19e639e14cef6e41eR52) with multiple slashes. Added tests for latter upstream and yaml here
@ldez Thanks for all the help on this! 🙏 > I think that the reassignment should be handled even inside the same package. Yeah this is something that came to...
Thanks @cowtowncoder so I guess it could be an accessor to the symbol table on the three main parser implementations. I'm a bit unsure what the exact form of the...