Adam Cmiel

Results 35 comments of Adam Cmiel

Also: in some cases, rather than copying just one item, buildah fails with this error ``` error building at STEP "COPY velero/* /dest": error renaming "/home/acmiel/investigation/podman-copy-error/velero/*": internal error: renamed 42...

That does make sense to me. But now that you mention wildcards that resolve to a single file, I think I've seen Dockerfiles that rely on this behavior. I can't...

> Sounds reasonable. Is the default of "--select-catalogers directory" the best one for build context directories? Yes, I think so

The submariner/lighthouse manifest looks perfect to me :+1: Ideally, we could do some validation to make sure the content manifest will be generate-able

I decided to test a particularly nasty example (sorry): https://github.com/cachito-testing/cachito-gomod-local-parent-deps/commit/584bdfdb70279d2ada6e68028a684b6c8afa0767 Request: ```json { "repo": "https://github.com/cachito-testing/cachito-gomod-local-parent-deps", "ref": "584bdfdb70279d2ada6e68028a684b6c8afa0767", "pkg_managers": ["gomod"], "packages": { "gomod": [{"path": "."}, {"path": "foo-module"}, {"path": "foo-module/bar-module"}] } }...

LGTM, there's just one lgtm-bot alert which could be easily addressed And the CI is failing for unrelated reasons, being fixed in #780

A library might be a better idea, https://github.com/inyutin/aiohttp_retry or at least backoff

> Add retry_client to get_dependencies The title of the PR might make a better commit message, it would also be good to include the Jira ID And the new code...

Given, for example, a git dependency in requirements.txt such as [this one](https://github.com/containerbuildsystem/atomic-reactor/blob/e2a8768038ef6ae7628a78c9dc9e86b373b605d0/requirements.txt#L51) ``` osbs-client @ git+https://github.com/containerbuildsystem/osbs-client@2bd03f4e0e5edc474b6236c5c128620d988f79a3 ``` Would this be an incorrect way to report it in CycloneDX? ```json {...

@stevespringett what did you have in mind with the compositions? Would you be able to provide an example of what that would look like?