Andrew Chinery
Andrew Chinery
Just been reading the code a bit more, and realised that other parts of the stitching pipeline don't make the `operator ()` function virtual either. Instead, in e.g. `motion_estimators.hpp`, in...
As a final note on this from uneducated me... in terms of the Python bindings not working, I think the alternative to making the operator virtual might be to add...
Just looking at the tests above, it looks like the macOS-ARM64 build just failed to clone the repo due a timeout, not sure why, but can someone resubmit that test?...
The test seems to be failing because it is unable to clone `opencv-extras` from my personal GitHub, probably because I did not make any changes there and so didn't fork...
@asmorkalov I'll add a C++ test for point 1ii. Is there a place I can add Python test code? Or should I just put the snippet here?
Don't worry have found the Python tests and added some
The previous test failed due to some bad whitespace, I have just re-committed with that fixed
HI @asmorkalov sorry could you retrigger the tests, they just seemed to fail on formatting before which I've hopefully fixed.
Hi all, is there anything left to do before this can be approved? Thanks!
Hi @asmorkalov, @alalek, sorry for the extra mention, but could you take a look and see if there's anything outstanding for this pull request? Thanks.