Mitchell
Mitchell
Hey @keeprocking are you still looking for help on this?
#45 adds a new `GelfHttpsHandler` class. I've put some details in the PR. I did not add any tests. I can give that a go this week.
No rush - hope you feel better soon! I added tests for the new handler. They all pass locally. However, I'm not able to get tests to pass with certificate...
Ah, ok, I'm able to run tests with certificate verification now. There are two issues with the TLS tests currently: 1. The certificate in `tests/config/` is expired 2. Graylog throws...
Done! I uncommented tests for `GelfTlsHandler` as well, they pass locally. I included a slightly modified version of the `/etc/pki/tls/certs/make-dummy-cert` script that OpenSSL installs on RHEL so that one can...
Happy to help!
PR #36 :)
@drunkbatya would you mind adding tests for this functionality? I believe you need to add new inputs [here](https://github.com/keeprocking/pygelf/blob/master/tests/config/graylog-setup.sh) and more params to `tests/test*.py` ([for example](https://github.com/keeprocking/pygelf/blob/master/tests/test_common_fields.py#L12))
There's a PR to do a big rewrite of the project and it looks like [it includes exactly what you're describing](https://github.com/briandowns/openweathermap/pull/90/files#diff-941e190d0ef19ffc088cd3c3ebe8d99916c2a65ef9d9194628c943df13ec3d5cR175-R181). @briandowns I really like the direction of the changes...
@briandowns do you mind if I work on adding support for the [statistics-api](https://openweathermap.org/api/statistics-api)?