Chiawen Chen

Results 44 comments of Chiawen Chen

The official post says that in comtrade data, the country tag "Other Asia" practically represent Taiwan.[[1]](http://unstats.un.org/unsd/tradekb/Knowledgebase/Taiwan-Province-of-China-Trade-data) So I think it is good to make the tag "Other asia" accessible from...

I think an simpler solution for your uses case is to add an option to allow dynamically (per-request) adding top-level property. For example: ```js app.use(expressionWinston.logger({ ...things, dynamicTopLevelMeta(req, res) { return...

Pressing escape key aborts the command.

The build script is not executed when people install this package by `yarn add https://github.com/timqian/chart.xkcd`, so there is no `dist` in the installed package. One way to solve this is...

It is redundant to specify both `required: false` and `default`. Having a default already implies `required: false`.

Your reasoning is based on `(A -> B) -> (!A -> !B)`, it is a logical fallacy called [fallacy of the inverse](https://en.wikipedia.org/wiki/Denying_the_antecedent).

I think stylelint cli should run fixer multiple times, like what [eslint does](https://eslint.org/docs/developer-guide/working-with-rules#applying-fixes). > After applying fixes, ESLint will run all of the enabled rules again on the fixed code,...

> Likewise do some use function expressions (or arrow functions) to denote functions for nested utilities that may be of less significance then those used as declarations. The schema you...

If the function param in jsdoc is inconsistent to that in code, which one is considered truth? Which one should be fixed?

Fixing jsdoc makes more sense. Fixing code is too much work because the fixer needs to find and change all references of the param, and deal with name collision and...