Christian Hagedorn comments

Results 64 comments of


                                            Christian Hagedorn

8289051: C2: Cleanup PhaseCCP::analyze()

Thanks Tobias for your review!

8289051: C2: Cleanup PhaseCCP::analyze()

Thanks Vladimir for your review! /integrate

8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region

Thanks Tobias for your review!

8291775: C2: assert(r != __null && r->is_Region()) failed: this phi must have a region

Thanks Vladimir for your review! /integrate

8293422: DWARF emitted by Clang cannot be parsed

Thanks Thomas for that link. I was not aware of this `-gdwarf-aranges` flag. I've tried it out and it indeed seems to work. But I was not able to build...

8293422: DWARF emitted by Clang cannot be parsed

Thanks Thomas for your review!

8293422: DWARF emitted by Clang cannot be parsed

That would be an option to bump that minimum version to get rid of the `ifdefs` for clang 5.0. But since this has quite an impact, are we allowed to...

8293422: DWARF emitted by Clang cannot be parsed

> If is is a big change or not depends on how it affects builds on macos. I assume that clang functionality that was published in 2017 is already incorporated...

8293422: DWARF emitted by Clang cannot be parsed

Thanks Magnus for your review of the build changes! May a get a second review of the DWARF parser code changes? Thanks, Christian

8280378: [IR Framework] Support IR matching for different compile phases

Thank you Vladimir! I forgot to mention that in the summary above. By default, I'm overriding repeated compile phases and only keep the output of the the very last compile...