Roman Hros

Results 29 comments of Roman Hros

When https://github.com/canonical/cloud-init/issues/4263 is resolved, IMHO it should be somehow possible to set localAPIEndpoint.advertiseAddress via cloud-init jinja templating.

According to our research in https://github.com/SovereignCloudStack/issues/issues/540, hostId should be available for all users. You can see e.g. in the nova code, that it is supported from API version 2.62 https://opendev.org/openstack/nova/commit/c2f7d6585818c04e626aa4b6c292e5c2660cb8b3....

> actually I can see both `hostId` and `host_id` which has same value. Perhaps that label could be added if it exists. This can be added in https://github.com/kubernetes/cloud-provider-openstack/blob/master/pkg/openstack/instancesv2.go#L136-L142 as AdditionalLabels...

> I think the value of HostID to a kubernetes cluster is the ability to schedule Pods on different underlying hypervisors. This means that an end-user can ensure their workload...

> > > I think the value of HostID to a kubernetes cluster is the ability to schedule Pods on different underlying hypervisors. This means that an end-user can ensure...

> > But which controller should be responsible for that? Right now, I am not aware of any. > > This PR is requesting that OpenStack CCM sets it, so...

I created PR so the discussion can move on. Can someone try it, please? You can use `registry.scs.community/occm-rh/openstack-cloud-controller-manager:v1.30.0-8-ga00ee1d8` image.

#2628 is approved. Should we merge it immediately and close this issue or if someone wants to look at it? I am not able to test migrations where host-id will...

> @chess-knight I agree, the label must be reconciled and updated once the node is live-migrated. I am not sure if OCCM is capable of doing that. Maybe after all...

Hi @mdbooth, thank you for your review. > @chess-knight As well as reconciling new Nodes, the node controller resyncs nodes periodically: https://github.com/kubernetes/kubernetes/blob/03fe89c2339a1582733649faab5f5df471f65f09/staging/src/k8s.io/cloud-provider/controllers/node/node_controller.go#L191-L198 > > However, it looks like that job:...