George Karpenkov

Results 96 comments of George Karpenkov

> I fixed all the comments in their respective commits and updated each commit description. When the system imports the PR, it squashes all the commits into one. It squashes...

No it was old, are you saying previously you saw PR being committed as multiple separate commits? I don't think that was ever the case?

> Any idea why it wasn't merged yet? Great question! Let me take a look.

> `ERROR: T:/src/github/tensorflow/tensorflow/python/util/BUILD:189:27: Linking tensorflow/python/util/_pywrap_checkpoint_reader.so failed: (Exit 1120): link.exe failed: error executing command` Windows build has failed. Let me try to rerun it.

Seems like an infra issue, escalated to infra team.

Infra got into a broken inconsistent state somehow. Unfortunately, our external compiler warnings don't have -Werror, so got this: ``` ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]...

Approved again internally. Sorry it's annoying multi-step process, we're trying to fix it.

Seems to be lost in copybara pipeline again. @reedwm could you investigate?

I was able to use this as a workaround: ``` let g:NERDLPlace = "/*" let g:NERDRPlace = "*/" ```